Bug 137923

Summary: [EME][Mac] Update to match new AVStreamSession API and requirements.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, philipj, sergio
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing
none
Patch for landing
none
Patch for landing none

Jer Noble
Reported 2014-10-21 08:17:38 PDT
[EME][Mac] Update to match new AVStreamSession API and requirements.
Attachments
Patch (25.87 KB, patch)
2014-10-21 09:06 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (25.67 KB, patch)
2014-10-21 14:35 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (25.73 KB, patch)
2014-10-21 15:48 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (25.73 KB, patch)
2014-10-21 15:49 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2014-10-21 09:06:50 PDT
Created attachment 240208 [details] Patch
Eric Carlson
Comment 2 2014-10-21 14:17:29 PDT
Comment on attachment 240208 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240208&action=review > Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:285 > + if (m_streamSession) { Minor nit: this could be an early return > Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:699 > + UNUSED_PARAM(trackID); Nit: this could be in an "#else" block below.
Jer Noble
Comment 3 2014-10-21 14:35:57 PDT
Created attachment 240222 [details] Patch for landing
Jer Noble
Comment 4 2014-10-21 15:48:29 PDT
Created attachment 240224 [details] Patch for landing
Jer Noble
Comment 5 2014-10-21 15:49:02 PDT
Created attachment 240226 [details] Patch for landing
Jer Noble
Comment 6 2014-10-21 16:07:00 PDT
Committed r175000: <http://trac.webkit.org/changeset/175000>
Jer Noble
Comment 7 2014-12-16 13:28:18 PST
<rdar://problem/19269055>
Note You need to log in before you can comment on or make changes to this bug.