Bug 137920

Summary: [Curl] Optimization; avoid string reallocation.
Product: WebKit Reporter: peavo
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.christensen, bfulgham, commit-queue, galpeter
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description peavo 2014-10-21 06:36:13 PDT
Profiling reveals that the cookiesForDOM function is spending time on removing a character from a string.
Comment 1 peavo 2014-10-21 06:42:49 PDT
Created attachment 240198 [details]
Patch
Comment 2 Brent Fulgham 2014-10-21 12:05:51 PDT
Comment on attachment 240198 [details]
Patch

r=me. It's always great to avoid having to create/modify a string when all you want to do is query it!
Comment 3 peavo 2014-10-21 12:33:57 PDT
(In reply to comment #2)
> Comment on attachment 240198 [details]
> Patch
> 
> r=me. It's always great to avoid having to create/modify a string when all
> you want to do is query it!

Thanks!
Comment 4 WebKit Commit Bot 2014-10-21 12:41:46 PDT
Comment on attachment 240198 [details]
Patch

Clearing flags on attachment: 240198

Committed r174993: <http://trac.webkit.org/changeset/174993>
Comment 5 WebKit Commit Bot 2014-10-21 12:41:49 PDT
All reviewed patches have been landed.  Closing bug.