Bug 137920

Summary:

[Curl] Optimization; avoid string reallocation.

Product:

WebKit

Reporter:

peavo

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alex.christensen, bfulgham, commit-queue, galpeter

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

peavo

Reported 2014-10-21 06:36:13 PDT

Profiling reveals that the cookiesForDOM function is spending time on removing a character from a string.

Attachments
Patch (2.79 KB, patch) 2014-10-21 06:42 PDT, peavo	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

peavo

Comment 1 2014-10-21 06:42:49 PDT

Created attachment 240198 [details] Patch

Brent Fulgham

Comment 2 2014-10-21 12:05:51 PDT

Comment on attachment 240198 [details] Patch r=me. It's always great to avoid having to create/modify a string when all you want to do is query it!

peavo

Comment 3 2014-10-21 12:33:57 PDT

(In reply to comment #2) > Comment on attachment 240198 [details] > Patch > > r=me. It's always great to avoid having to create/modify a string when all > you want to do is query it! Thanks!

WebKit Commit Bot

Comment 4 2014-10-21 12:41:46 PDT

Comment on attachment 240198 [details] Patch Clearing flags on attachment: 240198 Committed r174993: <http://trac.webkit.org/changeset/174993>

WebKit Commit Bot

Comment 5 2014-10-21 12:41:49 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.