Bug 13791

Summary: Autogenerate the JS bindings for the HTMLIFrameElement and HTMLFrameElement
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 13779    
Description Flags
sam: review-
updated patch aroben: review+

Description Sam Weinig 2007-05-20 18:19:18 PDT
Patch forthcoming.
Comment 1 Sam Weinig 2007-05-20 18:22:40 PDT
Created attachment 14638 [details]
Comment 2 Adam Roben (:aroben) 2007-05-20 18:34:13 PDT
Comment on attachment 14638 [details]

Is it possible to merge JSHTMLFrameElementCustom.cpp and JSHTMLIFrameElementCustom.cpp into one file that uses HTMLFrameOwnerElement? It seems a shame to have this duplicated code.
Comment 3 Sam Weinig 2007-05-21 09:52:11 PDT
Created attachment 14643 [details]
updated patch

Instead of using [Custom] to implement the security check I have added a [CheckSecurity] attribute and updated the bindings scripts to handle it.  This should resolves the code duplication issue and makes the patch a little cleaner.
Comment 4 Adam Roben (:aroben) 2007-05-21 10:31:41 PDT
Comment on attachment 14643 [details]
updated patch

+ // alias for DOM JS DOM bindings

I don't think you need two of them are needed.

Comment 5 Sam Weinig 2007-05-21 15:52:47 PDT
Landed in r21624.