Bug 137898

Summary: Action menu items should have tags
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, commit-queue, sam, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Description Beth Dakin 2014-10-20 16:09:38 PDT 
Action menu items should have tags.
Comment 1 Beth Dakin 2014-10-20 16:11:23 PDT 
Created attachment 240156 [details]
Patch
Comment 2 WebKit Commit Bot 2014-10-20 16:12:38 PDT 
Attachment 240156 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:58:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Beth Dakin 2014-10-20 16:14:09 PDT 
(In reply to comment #2)
> Attachment 240156 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:58:  Alphabetical sorting
> problem.  [build/include_order] [4]
> Total errors found: 1 in 4 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

Fixed!
Comment 4 Anders Carlsson 2014-10-20 16:19:39 PDT 
Comment on attachment 240156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240156&action=review

> Source/WebKit2/Shared/API/c/WKActionMenuItemTypes.h:41
> +typedef uint32_t WKActionMenuItemTag;

I don't think we need this typedef, do we!
Comment 5 Beth Dakin 2014-10-20 16:26:35 PDT 
(In reply to comment #4)
> Comment on attachment 240156 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240156&action=review
> 
> > Source/WebKit2/Shared/API/c/WKActionMenuItemTypes.h:41
> > +typedef uint32_t WKActionMenuItemTag;
> 
> I don't think we need this typedef, do we!

Good point!

http://trac.webkit.org/changeset/174913

Thanks Anders!
Comment 6 Joseph Pecoraro 2014-10-20 16:29:21 PDT 
Comment on attachment 240156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240156&action=review

> Source/WebKit2/Shared/API/c/WKActionMenuItemTypes.h:29
> +#include <stdint.h>

Does that mean this include can go away too?