Bug 137895

Summary: REGRESSION: Google Search (mobile) video thumbnails are too large.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, stavila, zalan
Priority: P2 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description zalan 2014-10-20 14:30:38 PDT 
1. Open google.com with iOS user agent string.
1. Search for something with videos.
3. Tap the "videos".
Notice that the video thumbnail overlay the title/text.
Comment 1 zalan 2014-10-20 14:31:57 PDT 
rdar://problem/18559546
Comment 2 zalan 2014-10-20 17:51:31 PDT 
Created attachment 240167 [details]
Patch
Comment 3 Simon Fraser (smfr) 2014-10-20 17:54:09 PDT 
Comment on attachment 240167 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240167&action=review

> Source/WebCore/rendering/RenderLayer.h:101
> +    bool effectedByRadius() const { return m_effectedByRadius; }
> +    void setEffectedByRadius(bool effectedByRadius) { m_effectedByRadius = effectedByRadius; }

effected -> affected everywhere.
Comment 4 zalan 2014-10-21 08:57:23 PDT 
Created attachment 240207 [details]
Patch
Comment 5 WebKit Commit Bot 2014-10-21 10:32:12 PDT 
Comment on attachment 240207 [details]
Patch

Clearing flags on attachment: 240207

Committed r174986: <http://trac.webkit.org/changeset/174986>
Comment 6 WebKit Commit Bot 2014-10-21 10:32:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Simon Fraser (smfr) 2014-11-12 21:30:30 PST 
This broke css "clip".