Bug 137886

Summary: Fix placement of a few items in vcxproj ItemGroups
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
The patch. ggaren: review+

Mark Lam
Reported 2014-10-20 11:13:30 PDT
https://bugs.webkit.org/show_bug.cgi?id=137873 is likely a cut-and-paste error that manifested because we had ClCompile and ClInclude entries mixed up in the wrong ItemGroups. We should fix these so that ClCompile entries are in the ClCompile ItemGroup, and ClInclude entries in the ClInclude ItemGroup. This will help reduce the change of future cut-and-paste errors of this nature.
Attachments
The patch. (4.59 KB, patch)
2014-10-20 11:20 PDT, Mark Lam 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-10-20 11:19:11 PDT
(In reply to comment #0) > https://bugs.webkit.org/show_bug.cgi?id=137873 is likely a cut-and-paste > error that manifested because we had ClCompile and ClInclude entries mixed > up in the wrong ItemGroups. We should fix these so that ClCompile entries > are in the ClCompile ItemGroup, and ClInclude entries in the ClInclude > ItemGroup. This will help reduce the change of future cut-and-paste errors > of this nature. This is a great idea. We should also extend the style checker to look for these kinds of things.
Mark Lam
Comment 2 2014-10-20 11:20:38 PDT
Created attachment 240130 [details] The patch. Here's the patch, but I'm still need to test this with an actual build before committing.
Geoffrey Garen
Comment 3 2014-10-20 11:24:24 PDT
Comment on attachment 240130 [details] The patch. r=me if it builds
Mark Lam
Comment 4 2014-10-20 11:27:38 PDT
It builds. I'll land manually.
Mark Lam
Comment 5 2014-10-20 11:30:30 PDT
Thanks for the review. Landed in r174895: <http://trac.webkit.org/r174895>.
Note You need to log in before you can comment on or make changes to this bug.