Bug 137885

Summary: Make post checkin suggested changes to r174847
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: WebCore JavaScriptAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Description Michael Saboff 2014-10-20 10:55:09 PDT 
From https://bugs.webkit.org/show_bug.cgi?id=137839#c4

View in context: https://bugs.webkit.org/attachment.cgi?id=240045&action=review

> Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp:65
> +    if (propertyName == Identifier(exec, "open")) {

I believe this is less efficient than:

    if (propertyName == "open") {

> Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp:76
> +    const HashTableValue* entry = JSHTMLDocument::info()->staticPropHashTable->entry(propertyName);
> +    if (entry) {

Would be nice to put this definition inside the if.
Comment 1 Michael Saboff 2014-10-20 14:49:23 PDT 
Created attachment 240147 [details]
Patch
Comment 2 Mark Lam 2014-10-20 15:24:23 PDT 
Comment on attachment 240147 [details]
Patch

r=me
Comment 3 Michael Saboff 2014-10-20 16:37:59 PDT 
Committed r174913: <http://trac.webkit.org/changeset/174913>
Comment 4 Michael Saboff 2014-10-20 18:20:17 PDT 
(In reply to comment #3)
> Committed r174913: <http://trac.webkit.org/changeset/174913>

Changes didn't land with this revision due to webkit-patch issue.
Comment 5 Michael Saboff 2014-10-20 18:21:00 PDT 
Committed r174918: <http://trac.webkit.org/changeset/174918>