Bug 137884

Summary: [GTK] Move GtkInputMethodFilter from Platform to WebKit2
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gustavo, pnormand, svillar
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Updated the apply on current git master gustavo: review+

Carlos Garcia Campos
Reported 2014-10-20 10:06:34 PDT
And merge it with WebViewBaseInputMethodFilter.
Attachments
Patch (80.88 KB, patch)
2014-10-20 10:18 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated the apply on current git master (80.83 KB, patch)
2014-10-20 10:27 PDT, Carlos Garcia Campos 		gustavo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2014-10-20 10:18:31 PDT
Created attachment 240128 [details] Patch
Carlos Garcia Campos
Comment 2 2014-10-20 10:27:18 PDT
Created attachment 240129 [details] Updated the apply on current git master
WebKit Commit Bot
Comment 3 2014-10-20 10:29:51 PDT
Attachment 240129 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/gtk/InputMethodFilter.cpp:143: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/gtk/InputMethodFilter.cpp:249: Missing space before { [whitespace/braces] [5] Total errors found: 2 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gustavo Noronha (kov)
Comment 4 2014-10-22 04:04:25 PDT
Comment on attachment 240129 [details] Updated the apply on current git master This rocks =)
Carlos Garcia Campos
Comment 5 2014-10-22 06:00:19 PDT
Committed r175046: <http://trac.webkit.org/changeset/175046>
Note You need to log in before you can comment on or make changes to this bug.