Bug 137874

Summary: Use std::unique_ptr<>|make_unique<> in PluginView::scheduleRequest()
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebCore Misc.Assignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for ews
none
Patch
none
Patch for landing none

Gyuyoung Kim
Reported 2014-10-20 04:04:40 PDT
SSIA
Attachments
Patch for ews (3.45 KB, patch)
2014-10-20 04:09 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (3.42 KB, patch)
2014-10-20 07:10 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.41 KB, patch)
2014-10-20 14:15 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2014-10-20 04:09:24 PDT
Created attachment 240107 [details] Patch for ews
Gyuyoung Kim
Comment 2 2014-10-20 07:10:19 PDT
Created attachment 240120 [details] Patch
Andreas Kling
Comment 3 2014-10-20 09:05:17 PDT
Comment on attachment 240120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240120&action=review r=me > Source/WebCore/plugins/PluginView.h:348 > + Vector<std::unique_ptr<PluginRequest> > m_requests; We no longer need the space between > and >.
Gyuyoung Kim
Comment 4 2014-10-20 14:15:13 PDT
Created attachment 240144 [details] Patch for landing
Gyuyoung Kim
Comment 5 2014-10-20 14:15:47 PDT
(In reply to comment #3) > Comment on attachment 240120 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=240120&action=review > > r=me > > > Source/WebCore/plugins/PluginView.h:348 > > + Vector<std::unique_ptr<PluginRequest> > m_requests; > > We no longer need the space between > and >. Thanks, done.
WebKit Commit Bot
Comment 6 2014-10-20 16:22:28 PDT
Comment on attachment 240144 [details] Patch for landing Clearing flags on attachment: 240144 Committed r174911: <http://trac.webkit.org/changeset/174911>
WebKit Commit Bot
Comment 7 2014-10-20 16:22:32 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 8 2014-10-20 16:24:51 PDT
Comment on attachment 240144 [details] Patch for landing I think the OwnPtr.h #include can be removed. While making these cleanups, as a bonus you may be able to remove headers for even more cleanup!
Gyuyoung Kim
Comment 9 2014-10-20 16:26:35 PDT
(In reply to comment #8) > Comment on attachment 240144 [details] > Patch for landing > > I think the OwnPtr.h #include can be removed. While making these cleanups, > as a bonus you may be able to remove headers for even more cleanup! Sure, I also have tried to remove those #include though, some #include has been missed. Let me try to remove it further !
Note You need to log in before you can comment on or make changes to this bug.