Bug 137874

Summary: Use std::unique_ptr<>|make_unique<> in PluginView::scheduleRequest()
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebCore Misc.Assignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for ews
none
Patch
none
Patch for landing none

Description Gyuyoung Kim 2014-10-20 04:04:40 PDT 
SSIA
Comment 1 Gyuyoung Kim 2014-10-20 04:09:24 PDT 
Created attachment 240107 [details]
Patch for ews
Comment 2 Gyuyoung Kim 2014-10-20 07:10:19 PDT 
Created attachment 240120 [details]
Patch
Comment 3 Andreas Kling 2014-10-20 09:05:17 PDT 
Comment on attachment 240120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240120&action=review

r=me

> Source/WebCore/plugins/PluginView.h:348
> +        Vector<std::unique_ptr<PluginRequest> > m_requests;

We no longer need the space between > and >.
Comment 4 Gyuyoung Kim 2014-10-20 14:15:13 PDT 
Created attachment 240144 [details]
Patch for landing
Comment 5 Gyuyoung Kim 2014-10-20 14:15:47 PDT 
(In reply to comment #3)
> Comment on attachment 240120 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240120&action=review
> 
> r=me
> 
> > Source/WebCore/plugins/PluginView.h:348
> > +        Vector<std::unique_ptr<PluginRequest> > m_requests;
> 
> We no longer need the space between > and >.

Thanks, done.
Comment 6 WebKit Commit Bot 2014-10-20 16:22:28 PDT 
Comment on attachment 240144 [details]
Patch for landing

Clearing flags on attachment: 240144

Committed r174911: <http://trac.webkit.org/changeset/174911>
Comment 7 WebKit Commit Bot 2014-10-20 16:22:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Joseph Pecoraro 2014-10-20 16:24:51 PDT 
Comment on attachment 240144 [details]
Patch for landing

I think the OwnPtr.h #include can be removed. While making these cleanups, as a bonus you may be able to remove headers for even more cleanup!
Comment 9 Gyuyoung Kim 2014-10-20 16:26:35 PDT 
(In reply to comment #8)
> Comment on attachment 240144 [details]
> Patch for landing
> 
> I think the OwnPtr.h #include can be removed. While making these cleanups,
> as a bonus you may be able to remove headers for even more cleanup!

Sure, I also have tried to remove those #include though, some #include has been missed. Let me try to remove it further !