Summary: | [EFL] build break occurs on webkit efl build. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | KwangHyuk <hyuki.kim> | ||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Minor | CC: | benjamin, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | Linux | ||||||
Bug Depends on: | 137802 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
KwangHyuk
2014-10-17 20:03:57 PDT
Created attachment 240056 [details]
Patch
Comment on attachment 240056 [details]
Patch
I believe this was fixed already?
(In reply to comment #2) > Comment on attachment 240056 [details] > Patch > > I believe this was fixed already? (In reply to comment #2) > Comment on attachment 240056 [details] > Patch > > I believe this was fixed already? Unfortunately, Nobody touch it yet. unused-but-set-variable. :) Could you see the code below ? unsigned elementAddressRegisterIndex = std::numeric_limits<unsigned>::max(); unsigned elementToTestIndex = std::numeric_limits<unsigned>::max(); bool isElementToMatchOnStack = false; if (selectorList.clobberElementAddressRegister) { if (elementToMatch != elementAddressRegister) { registersToSave.append(elementAddressRegister); registersToSave.append(elementToMatch); elementAddressRegisterIndex = 0; elementToTestIndex = 1; isElementToMatchOnStack = true; } else { registersToSave.append(elementAddressRegister); elementAddressRegisterIndex = 0; elementToTestIndex = 0; } } else if (elementToMatch != elementAddressRegister) { registersToSave.append(elementAddressRegister); elementAddressRegisterIndex = 0; } Comment on attachment 240056 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240056&action=review > Source/WebCore/cssjit/SelectorCompiler.cpp:1701 > + unsigned elementToTestIndex = elementAddressRegisterIndex; I'm not sure whether this is correct fix. I think Benjamin needs to take a look this. *** Bug 137847 has been marked as a duplicate of this bug. *** (In reply to comment #5) > *** Bug 137847 has been marked as a duplicate of this bug. *** This is just for keeping code that any author of this code wrote before without any side-effect. :) I just want to fix build break for my webkit efl build. Comment on attachment 240056 [details]
Patch
I believe that this fix doesn't change behavior. rs=me to fix EFL build break for now.
Comment on attachment 240056 [details] Patch Clearing flags on attachment: 240056 Committed r174859: <http://trac.webkit.org/changeset/174859> All reviewed patches have been landed. Closing bug. I am sorry I broke EFL, I thought the bot was red because of the StackAllocator changes. Thanks for fixing. I'll clean up that code. |