Bug 137805

Summary:

REGRESSION (r170808): Volume slider in built-in media controls only changes volume when thumb is released, not while dragging

Product:

WebKit

Reporter:

mitz

Component:

Media

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, commit-queue, dino, eric.carlson, glenn, graouts, gyuyoung.kim, hs85.jeong, jer.noble, jonlee, philipj, pom, roger_fong, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar, Regression

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

http://movies.apple.com/movies/us/apple/ipoditunes/2007/touch/ads/apple_ipodtouch_touch_r640-9cie.mov

Bug Depends on:

Bug Blocks:

137917

Attachments:

Description	Flags
Patch	mitz: review+
Patch for landing	none

Description mitz 2014-10-16 21:43:37 PDT

The volume slider in the built-in media controls doesn’t change the volume continuously as the thumb is being dragged. Instead, volume only changes when it’s released.

To reproduce: navigate to the URL. When music starts playing, hover over the volume button in the media controls, then click and hold the thumb in the volume slider, and while still holding, drag it downwards. Notice that the volume doesn’t decrease. Release the thumb and notice that the volume drops.

This is a regression, caused by <http://trac.webkit.org/r170808>, the fix for bug 134545.

Comment 1 Jon Lee 2014-10-16 21:53:11 PDT

This affects scrubber behavior as well.

Comment 2 mitz 2014-10-16 22:05:07 PDT

rdar://problem/18687059

Comment 3 pom 2014-10-17 03:16:39 PDT

This is *probably* caused by the volume slider relying on the incorrect behavior of the “change” event and should instead use the “input” event. I do not see a problem with the scrubber though (which was updated to use the “input” event.)

Comment 4 pom 2014-10-17 05:46:44 PDT

The problem is probably here: http://trac.webkit.org/browser/trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js#L388

The event name should be changed to “input” from “change” (see also line 337 where the timeline was updated correctly.)

Comment 5 Jer Noble 2014-10-17 14:49:16 PDT

*** Bug 137821 has been marked as a duplicate of this bug. ***

Comment 6 Jer Noble 2014-10-17 14:49:21 PDT

Created attachment 240041 [details]
Patch

Comment 7 Jer Noble 2014-10-20 08:35:35 PDT

Created attachment 240125 [details]
Patch for landing

Comment 8 Jer Noble 2014-10-21 09:28:34 PDT

Committed r174972: <http://trac.webkit.org/changeset/174972>

Comment 9 Hunseop Jeong 2016-04-25 18:51:30 PDT

This bug also was seen on EFL port.
Do I apply this patch to 'mediaControlsBase.js'?
I made the bug : https://bugs.webkit.org/show_bug.cgi?id=156970.