REGRESSION (r21526): Failing fast/parser/bad-xml-slash.html

• Component: New Bugs
• Status: RESOLVED FIXED

fast/parser/bad-xml-slash.html is failing: when opened in r21528 and later, the checkbox is not checked.

The render trees for a selected checkbox and an unselected checkbox are the same, so the failure is only reported when running in pixel mode. I think the test should be changed, if possible, to use the DOM to get the status of the checkbox and dump the result as text.

Most likely regressed in <http://trac.webkit.org/projects/webkit/changeset/21526>.

[Dave Hyatt]

Created attachment 14614 [details]
Patch that fixes "/" to no longer be an attribute name ever.

This patch fixes "/" to no longer ever be part of attribute names (so that it's handled like HTML5 and not like HTML4).

It also became necessary to move the <script/> quirk when doing this since it was relying on "/" being an attribute name.  Since i had to redo that quirk, I went ahead and made sure it only applied to Dashboard as well.  This affects a lot of layout tests that I will patch.

[Dave Hyatt]

Created attachment 14615 [details]
Address some comments from IRC.

Null-check frame() and use frame()->settings() rather than frame()->page()->settings()

[Geoffrey Garen]

Comment on attachment 14615 [details]
Address some comments from IRC.

r=me

[Dave Hyatt]

Fixed.