Bug 13780

Summary:

REGRESSION (r21526): Failing fast/parser/bad-xml-slash.html

Product:

WebKit

Reporter:

mitz

Component:

New Bugs

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hyatt

Priority:

Keywords:

LayoutTestFailure, Regression

Version:

523.x (Safari 3)

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Patch that fixes "/" to no longer be an attribute name ever.	none
Address some comments from IRC.	ggaren: review+

mitz

Reported 2007-05-18 12:43:49 PDT

fast/parser/bad-xml-slash.html is failing: when opened in r21528 and later, the checkbox is not checked. The render trees for a selected checkbox and an unselected checkbox are the same, so the failure is only reported when running in pixel mode. I think the test should be changed, if possible, to use the DOM to get the status of the checkbox and dump the result as text.

Attachments
Patch that fixes "/" to no longer be an attribute name ever. (4.02 KB, patch) 2007-05-18 15:02 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
Address some comments from IRC. (3.83 KB, patch) 2007-05-18 15:23 PDT, Dave Hyatt	ggaren: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2007-05-18 12:47:30 PDT

Most likely regressed in <http://trac.webkit.org/projects/webkit/changeset/21526>.

Dave Hyatt

Comment 2 2007-05-18 15:02:30 PDT

Created attachment 14614 [details] Patch that fixes "/" to no longer be an attribute name ever. This patch fixes "/" to no longer ever be part of attribute names (so that it's handled like HTML5 and not like HTML4). It also became necessary to move the <script/> quirk when doing this since it was relying on "/" being an attribute name. Since i had to redo that quirk, I went ahead and made sure it only applied to Dashboard as well. This affects a lot of layout tests that I will patch.

Dave Hyatt

Comment 3 2007-05-18 15:23:16 PDT

Created attachment 14615 [details] Address some comments from IRC. Null-check frame() and use frame()->settings() rather than frame()->page()->settings()

Geoffrey Garen

Comment 4 2007-05-18 15:43:09 PDT

Comment on attachment 14615 [details] Address some comments from IRC. r=me

Dave Hyatt

Comment 5 2007-05-18 16:08:08 PDT

Fixed.

Note You need to log in before you can comment on or make changes to this bug.