Bug 137795 – commit-queue: fails to replace OO-PS! with reviewer name

• Component: Tools / Tests
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

After the Bugzilla 4.2.11 update, the commit-queue sometimes fails to replace the OO-PS! text with the reviewer name.

For example:  <https://webkit-queues.appspot.com/patch/239923>

<https://webkit-queues.appspot.com/results/5777270190899200>

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 239923, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

[David Kilzer (:ddkilzer)]

Oliver thinks this may be the same issue:

$ ./Tools/Scripts/webkit-patch land 137766
Fetching: https://bugs.webkit.org/show_bug.cgi?id=137766&ctype=xml&excludefield=attachmentdata
Warning, attachment 239923 [details] on bug 137766 has invalid reviewer (akling)
No reviewed patches on bug 137766, cannot infer reviewer.
Failed to guess reviewer from bug 137766 and --reviewer= not provided.  Not updating ChangeLogs with reviewer.
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html

Looks like webkit-patch isn't able to fetch the reviewer list?

[David Kilzer (:ddkilzer)]

(In reply to comment #1)
> Looks like webkit-patch isn't able to fetch the reviewer list?

Bugzilla changed to not expose email addresses when no one is logged in, so webkit-patch is loading this URL without logging in first:

https://bugs.webkit.org/show_bug.cgi?id=137766&ctype=xml&excludefield=attachmentdata

And getting <flag> elements like this:

<flag name="review" id="264671" type_id="1" status="+" setter="akling"/>
<flag name="commit-queue" id="264709" type_id="3" status="+" setter="cdumez"/>

Instead of like this (after logging in):

<flag name="review" id="264671" type_id="1" status="+" setter="[e-mail]"/>
<flag name="commit-queue" id="264709" type_id="3" status="+" setter="[e-mail]"/>

The fix is to make sure webkit-patch logs in before fetching attachment data.

[David Kilzer (:ddkilzer)]

Created attachment 239983 [details]
Patch v1

[David Kilzer (:ddkilzer)]

Committed r174800: <http://trac.webkit.org/changeset/174800>

[David Kilzer (:ddkilzer)]

(In reply to comment #4)
> Committed r174800: <http://trac.webkit.org/changeset/174800>

NOTE: I haven't been able to verify if this is the only fix needed, but this is needed before we determine what the next issue is.