Summary: | commit-queue: fails to close bugs after successfully landing patches | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Component: | Tools / Tests | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, commit-queue, glenn, ossy, rniwa | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2014-10-16 15:29:21 PDT
Using Web Inspector, it looks like there are two <textarea> elements with the name "comment", and Mechanize is choosing the first one: Load: <https://bugs.webkit.org/attachment.cgi?id=239956&action=edit> #1: <textarea name="comment" id="editFrame" class="bz_default_hidden" wrap="soft" disabled="disabled" rows="10" cols="80"> #2: <textarea name="comment" id="comment" wrap="soft" rows="10" cols="80"> I think changing line 757 in bugzilla.py will fix this: - self.browser.set_value(comment_text, name='comment', nr=0) + self.browser.set_value(comment_text, name='comment', nr=1) Created attachment 239979 [details]
Patch v1
Committed r174797: <http://trac.webkit.org/changeset/174797> |