| Summary: | Fix FTL Native Inlining for EFL | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dániel Bátyai <dbatyai.u-szeged> | ||||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, cmarcelo, commit-queue, darin, fpizlo, gyuyoung.kim, lantw44, mark.lam, msaboff, mtiborinf, ossy, rakuco, ryuan.choi, sergio | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 145044 | ||||||||
| Bug Blocks: | 143605 | ||||||||
| Attachments: |
|
||||||||
|
Description
Dániel Bátyai
2014-10-16 02:26:57 PDT
Created attachment 239940 [details]
Patch
Initial WIP.
Added required functionality and updated CMake to generate the required bitcode.
There is a small issue with the script generating InlineRuntmeSymbolTable.h,
but overall the inlining is working correctly.
Created attachment 239943 [details]
Patch
Added missing files
Attachment 239943 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/CMakeLists.txt:795: There should be exactly one empty line instead of 0 between "inspector" and "inspector/agents". [list/emptyline] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:797: Alphabetical sorting problem. "interpreter" should be before "inspector/remote". [list/order] [5]
Total errors found: 2 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 239943 [details]
Patch
r=me
Comment on attachment 239943 [details] Patch Clearing flags on attachment: 239943 Committed r174940: <http://trac.webkit.org/changeset/174940> All reviewed patches have been landed. Closing bug. This patch causes compilation error on FreeBSD 10.1. program_invocation_name is a GNU extension, so it should not be used unconditionally.
Source/JavaScriptCore/runtime/BundlePath.cpp:41:42: error: use of undeclared identifier 'program_invocation_name'
std::string programPath(realpath(program_invocation_name, 0));
^
1 error generated.
(In reply to comment #7) > This patch causes compilation error on FreeBSD 10.1. program_invocation_name > is a GNU extension, so it should not be used unconditionally. > > Source/JavaScriptCore/runtime/BundlePath.cpp:41:42: error: use of undeclared > identifier 'program_invocation_name' > std::string programPath(realpath(program_invocation_name, 0)); > ^ > 1 error generated. Hi Ting-Wei Lan! https://bugs.webkit.org/show_bug.cgi?id=137924 will fix this problem. |