| Summary: | CSS JIT: Introduce addressToStackReference | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Yusuke Suzuki
2014-10-15 23:50:55 PDT
Created attachment 239934 [details]
Patch
Created attachment 239938 [details]
Patch
Comment on attachment 239938 [details]
Patch
That's a great idea, this cleans up the code and make it harder to misuse the stack.
I think the name addressToStackReference can be confusing. What do you think of:
-stackReferenceAddress()
-addressOfStackReference()
or simply
-addressOf(StackReference)
(In reply to comment #3) > Comment on attachment 239938 [details] > Patch > > That's a great idea, this cleans up the code and make it harder to misuse > the stack. > > I think the name addressToStackReference can be confusing. What do you think > of: > -stackReferenceAddress() > -addressOfStackReference() > or simply > -addressOf(StackReference) `addressOf` looks very nice :), its name and parameter's type describes the role of the function clearly. I'll apply this change and land the patch. Committed r174810: <http://trac.webkit.org/changeset/174810> |