Bug 137757

Summary:

REGRESSION(r171593) [Mac] Media controls create a large (and unnecessary) backing store

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, buildbot, calvaris, commit-queue, eric.carlson, glenn, jonlee, philipj, rniwa, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion	none
Patch for landing	ap: review-
Patch for landing	none

Jer Noble

Reported 2014-10-15 16:10:58 PDT

[Mac] Controls create a large (and unnecessary) backing store

Attachments
Patch (17.10 KB, patch) 2014-10-15 16:38 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (16.67 KB, patch) 2014-10-15 16:48 PDT, Jer Noble	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (860.01 KB, application/zip) 2014-10-15 17:55 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (615.36 KB, application/zip) 2014-10-15 19:35 PDT, Build Bot	no flags	Details
Patch for landing (1.73 MB, patch) 2014-10-15 19:43 PDT, Jer Noble	ap: review-	Details Formatted Diff Diff
Patch for landing (1.01 MB, patch) 2014-10-28 10:54 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2014-10-15 16:12:57 PDT

Regressed in <http://trac.webkit.org/r171593>.

Jer Noble

Comment 2 2014-10-15 16:38:22 PDT

Created attachment 239906 [details] Patch

Jer Noble

Comment 3 2014-10-15 16:48:47 PDT

Created attachment 239907 [details] Patch

Eric Carlson

Comment 4 2014-10-15 17:01:04 PDT

Comment on attachment 239907 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239907&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:142 > + Nit: extra blank line

Build Bot

Comment 5 2014-10-15 17:55:22 PDT

Comment on attachment 239907 [details] Patch Attachment 239907 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5130244105175040 New failing tests: media/video-no-audio.html media/controls-strict.html media/video-volume-slider.html media/video-display-toggle.html media/audio-controls-rendering.html media/video-zoom-controls.html media/video-controls-rendering.html media/controls-without-preload.html media/video-empty-source.html

Build Bot

Comment 6 2014-10-15 17:55:25 PDT

Created attachment 239910 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 7 2014-10-15 19:35:08 PDT

Comment on attachment 239907 [details] Patch Attachment 239907 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6327367454687232 Number of test failures exceeded the failure limit.

Build Bot

Comment 8 2014-10-15 19:35:13 PDT

Created attachment 239919 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Jer Noble

Comment 9 2014-10-15 19:43:41 PDT

Created attachment 239920 [details] Patch for landing

Alexey Proskuryakov

Comment 10 2014-10-20 13:06:47 PDT

Comment on attachment 239920 [details] Patch for landing Please don't land as is, EWS is seeing errors. Filed bug 137892 to make EWS smarter in this particular case. Unexpected text-only failures (10) media/audio-controls-rendering.html [ Failure ] media/controls-after-reload.html [ Failure ] media/controls-strict.html [ Failure ] media/controls-styling.html [ Failure ] media/controls-without-preload.html [ Failure ] media/video-controls-rendering.html [ Failure ] media/video-display-toggle.html [ Failure ] media/video-no-audio.html [ Failure ] media/video-volume-slider.html [ Failure ] media/video-zoom-controls.html [ Failure ]

Jer Noble

Comment 11 2014-10-20 13:22:22 PDT

(In reply to comment #10) > Comment on attachment 239920 [details] > Patch for landing > > Please don't land as is, EWS is seeing errors. Don't worry, I'm trying to fix these all before landing.

Jer Noble

Comment 12 2014-10-28 10:54:20 PDT

Created attachment 240557 [details] Patch for landing Rebaselined Yosemite and Mavericks results separately.

Jon Lee

Comment 13 2014-10-28 11:50:14 PDT

rdar://problem/18195906

Jer Noble

Comment 14 2014-10-28 12:37:26 PDT

Committed r175268: <http://trac.webkit.org/changeset/175268>

Jer Noble

Comment 15 2014-10-28 12:38:14 PDT

Removed the unintentional extra *-diff.html results from the last patch before landing.

Note You need to log in before you can comment on or make changes to this bug.