Bug 137753

Summary:

Web Inspector: InspectorBackendCommands should include when to activate particular domains

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

burg, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	timothy: review+

Description Joseph Pecoraro 2014-10-15 14:08:44 PDT

For JS debuggables, only some domains are active by default. For Web debuggables, all domains are active. This logic should be generated into the BackendCommands.

Comment 1 Radar WebKit Bug Importer 2014-10-15 14:09:09 PDT

<rdar://problem/18669637>

Comment 2 Radar WebKit Bug Importer 2014-10-15 14:09:11 PDT

<rdar://problem/18669638>

Comment 3 Joseph Pecoraro 2014-10-17 12:07:24 PDT

Created attachment 240029 [details]
[PATCH] Proposed Fix

Depends on bug 137748.

Comment 4 Timothy Hatcher 2014-10-18 01:07:51 PDT

Comment on attachment 240029 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=240029&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        Add an activate property to domains that only activate for

The property name "activate" reads funny since it is a verb. I expect only nouns for that purpose. Maybe "availability"? And since "js" isn't allowed, only "web", maybe "extendedAvailability"?

Otherwise the patch looks good.

Comment 5 Joseph Pecoraro 2014-10-20 11:01:38 PDT

I like availability.

Comment 6 Joseph Pecoraro 2014-10-20 13:45:28 PDT

http://trac.webkit.org/changeset/174906