Bug 137753

Summary: Web Inspector: InspectorBackendCommands should include when to activate particular domains
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: burg, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix timothy: review+

Joseph Pecoraro
Reported 2014-10-15 14:08:44 PDT
For JS debuggables, only some domains are active by default. For Web debuggables, all domains are active. This logic should be generated into the BackendCommands.
Attachments
[PATCH] Proposed Fix (62.45 KB, patch)
2014-10-17 12:07 PDT, Joseph Pecoraro 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-10-15 14:09:09 PDT
<rdar://problem/18669637>
Radar WebKit Bug Importer
Comment 2 2014-10-15 14:09:11 PDT
<rdar://problem/18669638>
Joseph Pecoraro
Comment 3 2014-10-17 12:07:24 PDT
Created attachment 240029 [details] [PATCH] Proposed Fix Depends on bug 137748.
Timothy Hatcher
Comment 4 2014-10-18 01:07:51 PDT
Comment on attachment 240029 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=240029&action=review > Source/JavaScriptCore/ChangeLog:8 > + Add an activate property to domains that only activate for The property name "activate" reads funny since it is a verb. I expect only nouns for that purpose. Maybe "availability"? And since "js" isn't allowed, only "web", maybe "extendedAvailability"? Otherwise the patch looks good.
Joseph Pecoraro
Comment 5 2014-10-20 11:01:38 PDT
I like availability.
Joseph Pecoraro
Comment 6 2014-10-20 13:45:28 PDT
http://trac.webkit.org/changeset/174906
Note You need to log in before you can comment on or make changes to this bug.