Bug 137741

Summary:

Removing CUSTOM_PROTOCOLS guard

Product:

WebKit

Reporter:

Pascal Jacquemart <p.jacquemart>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, commit-queue, darin, gyuyoung.kim, rakuco, ryuan.choi, sam, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Removing CUSTOM_PROTOCOLS guard	none

Description Pascal Jacquemart 2014-10-15 07:40:41 PDT

CUSTOM_PROTOCOLS is the default code path for all ports now since r174419 [EFL] "Enable custom URI schemes with CustomProtocols"

It is not a real feature since the flag is hard-coded (WebKit2Prefix.h for Mac and GTK / OptionsEfl.cmake for EFL)
Most ports won't compile without this flag (at least GTK and EFL). 

Also this CUSTOM_PROTOCOLS naming can be confusing against another real feature called CUSTOM_SCHEME_HANDLER

Comment 1 Pascal Jacquemart 2014-10-15 07:46:01 PDT

Created attachment 239872 [details]
Removing CUSTOM_PROTOCOLS guard

Comment 2 Darin Adler 2014-10-15 09:14:46 PDT

I don’t see any reason to wait. Seems like we should land this. Any objections?

Comment 3 Anders Carlsson 2014-10-15 09:18:34 PDT

(In reply to comment #2)
> I don’t see any reason to wait. Seems like we should land this. Any objections?

Nope, let's do it.

Comment 4 WebKit Commit Bot 2014-10-16 18:14:29 PDT

Comment on attachment 239872 [details]
Removing CUSTOM_PROTOCOLS guard

Clearing flags on attachment: 239872

Committed r174803: <http://trac.webkit.org/changeset/174803>

Comment 5 WebKit Commit Bot 2014-10-16 18:14:41 PDT

All reviewed patches have been landed.  Closing bug.