Bug 137726

Summary:

Clean up unnecessary PassOwnPtr.h inclusion

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

WebCore Misc.

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, cmarcelo, commit-queue, esprehn+autocc, jamesr, japhet, kangil.han, luiz, noam, ryuan.choi, sergio, tonikitoo, zeno

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch for ews	none
Patch for ews	none
Patch for ews	none
Patch for landing	none

Gyuyoung Kim

Reported 2014-10-14 18:53:42 PDT

As PassOwnPtr is replaced by unique_ptr, PassOwnPtr.h inclusion doesn't need to be included.

Attachments
Patch for ews (9.59 KB, patch) 2014-10-14 18:56 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch for ews (9.60 KB, patch) 2014-10-14 18:57 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch for ews (9.11 KB, patch) 2014-10-14 19:54 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch for landing (9.10 KB, patch) 2014-10-14 21:22 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Gyuyoung Kim

Comment 1 2014-10-14 18:56:41 PDT

Created attachment 239836 [details] Patch for ews

Gyuyoung Kim

Comment 2 2014-10-14 18:57:45 PDT

Created attachment 239837 [details] Patch for ews

Gyuyoung Kim

Comment 3 2014-10-14 19:54:41 PDT

Created attachment 239841 [details] Patch for ews

Chris Dumez

Comment 4 2014-10-14 20:57:21 PDT

Comment on attachment 239841 [details] Patch for ews View in context: https://bugs.webkit.org/attachment.cgi?id=239841&action=review r=me % nits > Source/JavaScriptCore/ChangeLog:3 > + Clean up redundant PassOwnPtr.h inclusion nit: I think you mean "unnecessary", not "redundant"

Gyuyoung Kim

Comment 5 2014-10-14 21:22:43 PDT

Created attachment 239848 [details] Patch for landing

Gyuyoung Kim

Comment 6 2014-10-14 21:23:29 PDT

(In reply to comment #4) > (From update of attachment 239841 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=239841&action=review > > r=me % nits > > > Source/JavaScriptCore/ChangeLog:3 > > + Clean up redundant PassOwnPtr.h inclusion > > nit: I think you mean "unnecessary", not "redundant" Oh, right ! Thanks.

WebKit Commit Bot

Comment 7 2014-10-14 22:05:58 PDT

Comment on attachment 239848 [details] Patch for landing Clearing flags on attachment: 239848 Committed r174723: <http://trac.webkit.org/changeset/174723>

WebKit Commit Bot

Comment 8 2014-10-14 22:06:05 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.