Bug 137726

Summary: Clean up unnecessary PassOwnPtr.h inclusion
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebCore Misc.Assignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cmarcelo, commit-queue, esprehn+autocc, jamesr, japhet, kangil.han, luiz, noam, ryuan.choi, sergio, tonikitoo, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for ews
none
Patch for ews
none
Patch for ews
none
Patch for landing none

Description Gyuyoung Kim 2014-10-14 18:53:42 PDT 
As PassOwnPtr is replaced by unique_ptr, PassOwnPtr.h inclusion doesn't need to be included.
Comment 1 Gyuyoung Kim 2014-10-14 18:56:41 PDT 
Created attachment 239836 [details]
Patch for ews
Comment 2 Gyuyoung Kim 2014-10-14 18:57:45 PDT 
Created attachment 239837 [details]
Patch for ews
Comment 3 Gyuyoung Kim 2014-10-14 19:54:41 PDT 
Created attachment 239841 [details]
Patch for ews
Comment 4 Chris Dumez 2014-10-14 20:57:21 PDT 
Comment on attachment 239841 [details]
Patch for ews

View in context: https://bugs.webkit.org/attachment.cgi?id=239841&action=review

r=me % nits

> Source/JavaScriptCore/ChangeLog:3
> +        Clean up redundant PassOwnPtr.h inclusion

nit: I think you mean "unnecessary", not "redundant"
Comment 5 Gyuyoung Kim 2014-10-14 21:22:43 PDT 
Created attachment 239848 [details]
Patch for landing
Comment 6 Gyuyoung Kim 2014-10-14 21:23:29 PDT 
(In reply to comment #4)
> (From update of attachment 239841 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=239841&action=review
> 
> r=me % nits
> 
> > Source/JavaScriptCore/ChangeLog:3
> > +        Clean up redundant PassOwnPtr.h inclusion
> 
> nit: I think you mean "unnecessary", not "redundant"

Oh, right ! Thanks.
Comment 7 WebKit Commit Bot 2014-10-14 22:05:58 PDT 
Comment on attachment 239848 [details]
Patch for landing

Clearing flags on attachment: 239848

Committed r174723: <http://trac.webkit.org/changeset/174723>
Comment 8 WebKit Commit Bot 2014-10-14 22:06:05 PDT 
All reviewed patches have been landed.  Closing bug.