Bug 137726 - Clean up unnecessary PassOwnPtr.h inclusion
Summary: Clean up unnecessary PassOwnPtr.h inclusion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-14 18:53 PDT by Gyuyoung Kim
Modified: 2014-10-14 22:06 PDT (History)
13 users (show)

See Also:

Attachments
Patch for ews (9.59 KB, patch)
2014-10-14 18:56 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch for ews (9.60 KB, patch)
2014-10-14 18:57 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch for ews (9.11 KB, patch)
2014-10-14 19:54 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch for landing (9.10 KB, patch)
2014-10-14 21:22 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2014-10-14 18:53:42 PDT 
As PassOwnPtr is replaced by unique_ptr, PassOwnPtr.h inclusion doesn't need to be included.
Comment 1 Gyuyoung Kim 2014-10-14 18:56:41 PDT 
Created attachment 239836 [details]
Patch for ews
Comment 2 Gyuyoung Kim 2014-10-14 18:57:45 PDT 
Created attachment 239837 [details]
Patch for ews
Comment 3 Gyuyoung Kim 2014-10-14 19:54:41 PDT 
Created attachment 239841 [details]
Patch for ews
Comment 4 Chris Dumez 2014-10-14 20:57:21 PDT 
Comment on attachment 239841 [details]
Patch for ews

View in context: https://bugs.webkit.org/attachment.cgi?id=239841&action=review

r=me % nits

> Source/JavaScriptCore/ChangeLog:3
> +        Clean up redundant PassOwnPtr.h inclusion

nit: I think you mean "unnecessary", not "redundant"
Comment 5 Gyuyoung Kim 2014-10-14 21:22:43 PDT 
Created attachment 239848 [details]
Patch for landing
Comment 6 Gyuyoung Kim 2014-10-14 21:23:29 PDT 
(In reply to comment #4)
> (From update of attachment 239841 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=239841&action=review
> 
> r=me % nits
> 
> > Source/JavaScriptCore/ChangeLog:3
> > +        Clean up redundant PassOwnPtr.h inclusion
> 
> nit: I think you mean "unnecessary", not "redundant"

Oh, right ! Thanks.
Comment 7 WebKit Commit Bot 2014-10-14 22:05:58 PDT 
Comment on attachment 239848 [details]
Patch for landing

Clearing flags on attachment: 239848

Committed r174723: <http://trac.webkit.org/changeset/174723>
Comment 8 WebKit Commit Bot 2014-10-14 22:06:05 PDT 
All reviewed patches have been landed.  Closing bug.