Bug 137722

Summary: Use is<>() / downcast<>() for PlatformCAAnimation subclasses
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: PlatformAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137056    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2014-10-14 15:39:57 PDT
Use is<>() / downcast<>() for PlatformCAAnimation subclasses.
Attachments
Patch (49.51 KB, patch)
2014-10-14 16:14 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (49.45 KB, patch)
2014-10-14 16:58 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-10-14 16:14:35 PDT
Created attachment 239830 [details] Patch
WebKit Commit Bot
Comment 2 2014-10-14 16:16:34 PDT
Attachment 239830 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/win/PlatformCAAnimationWin.cpp:435: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm:398: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm:455: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm:541: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 4 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 3 2014-10-14 16:58:01 PDT
Created attachment 239834 [details] Patch
WebKit Commit Bot
Comment 4 2014-10-14 17:00:18 PDT
Attachment 239834 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/win/PlatformCAAnimationWin.cpp:435: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm:398: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm:455: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm:541: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 4 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 5 2014-10-14 17:41:02 PDT
Comment on attachment 239834 [details] Patch Clearing flags on attachment: 239834 Committed r174715: <http://trac.webkit.org/changeset/174715>
WebKit Commit Bot
Comment 6 2014-10-14 17:41:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.