Bug 137678

Summary: Web Inspector: Remove unused stale Page protocol methods
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
kling: review+
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2014-10-13 16:39:42 PDT
We have a number of unused, stale, Page protocol methods:

  - canShowDebugBorders
  - setShowDebugBorders
  - canShowFPSCounter
  - setShowFPSCounter
  - canContinuouslyPaint
  - setContinuousPaintingEnabled

Lets remove these as they are unimplemented. We can implement and add them in the future.
Comment 1 Radar WebKit Bug Importer 2014-10-13 16:39:52 PDT
<rdar://problem/18641666>
Comment 2 Joseph Pecoraro 2014-10-13 16:42:38 PDT
Created attachment 239758 [details]
[PATCH] Proposed Fix
Comment 3 Andreas Kling 2014-10-13 16:53:47 PDT
Comment on attachment 239758 [details]
[PATCH] Proposed Fix

r=me
Comment 4 Joseph Pecoraro 2014-10-13 17:30:49 PDT
Created attachment 239765 [details]
[PATCH] Proposed Fix
Comment 5 WebKit Commit Bot 2014-10-13 18:30:10 PDT
Comment on attachment 239765 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 239765

Committed r174668: <http://trac.webkit.org/changeset/174668>
Comment 6 WebKit Commit Bot 2014-10-13 18:30:13 PDT
All reviewed patches have been landed.  Closing bug.