| Summary: | Improve the test image diffs page | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, commit-queue, dbates, dfarler, glenn, simon.fraser | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2014-10-13 14:59:56 PDT
Created attachment 239749 [details]
Patch
Attachment 239749 [details] did not pass style-queue:
ERROR: Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:178: multiple statements on one line (semicolon) [pep8/E702] [5]
ERROR: Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:179: multiple statements on one line (semicolon) [pep8/E702] [5]
Total errors found: 2 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 239750 [details]
Example
Comment on attachment 239749 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239749&action=review > LayoutTests/fast/harness/image-diff-template.html:91 > + ++preloadedImageCount; > + if (preloadedImageCount < 2) > + return; This is old code, but I don't understand why 2 is the right value here. We are preloading 3 images. > LayoutTests/fast/harness/image-diff-template.html:160 > + cycleIntervalID = 0; Could be undefined to match initial value. |