Bug 137674

Summary: Improve the test image diffs page
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, dbates, dfarler, glenn, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ap: review+
Example none

Simon Fraser (smfr)
Reported 2014-10-13 14:59:56 PDT
Improve the test image diffs page
Attachments
Patch (9.72 KB, patch)
2014-10-13 15:01 PDT, Simon Fraser (smfr) 		ap: review+
DetailsFormatted DiffDiff
Example (4.65 KB, text/html)
2014-10-13 15:05 PDT, Simon Fraser (smfr) 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-10-13 15:01:52 PDT
Created attachment 239749 [details] Patch
WebKit Commit Bot
Comment 2 2014-10-13 15:04:32 PDT
Attachment 239749 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:178: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:179: multiple statements on one line (semicolon) [pep8/E702] [5] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 3 2014-10-13 15:05:07 PDT
Created attachment 239750 [details] Example
Alexey Proskuryakov
Comment 4 2014-10-13 15:24:29 PDT
Comment on attachment 239749 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239749&action=review > LayoutTests/fast/harness/image-diff-template.html:91 > + ++preloadedImageCount; > + if (preloadedImageCount < 2) > + return; This is old code, but I don't understand why 2 is the right value here. We are preloading 3 images. > LayoutTests/fast/harness/image-diff-template.html:160 > + cycleIntervalID = 0; Could be undefined to match initial value.
Simon Fraser (smfr)
Comment 5 2014-10-13 15:45:07 PDT
https://trac.webkit.org/r174662
Note You need to log in before you can comment on or make changes to this bug.