Bug 137673

Summary:

[Win] Implement a page load profiling tool

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

Tools / Tests

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=200155

Attachments:

Description	Flags
Patch	dino: review+

Description Brent Fulgham 2014-10-13 14:27:22 PDT

Implement a page load profiling tool for Windows, based on the PLT tool and WinLauncher.

Comment 1 Radar WebKit Bug Importer 2014-10-13 14:52:26 PDT

<rdar://problem/18639562>

Comment 2 Brent Fulgham 2014-10-13 15:26:56 PDT

Created attachment 239751 [details]
Patch

Comment 3 WebKit Commit Bot 2014-10-13 15:29:47 PDT

Attachment 239751 [details] did not pass style-queue:


ERROR: Tools/WinLauncher/PageLoadTestClient.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/WinLauncher/PageLoadTestClient.cpp:27:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/WinLauncher/PageLoadTestClient.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Tools/WinLauncher/ResourceLoadDelegate.cpp:25:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/WinLauncher/ResourceLoadDelegate.cpp:26:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 5 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Brent Fulgham 2014-10-13 15:30:39 PDT

Note: These style errors are due to required include ordering on Windows. :-(

Comment 5 Dean Jackson 2014-10-13 15:36:02 PDT

Comment on attachment 239751 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239751&action=review

> Tools/WinLauncher/PageLoadTestClient.cpp:197
> +#if PLATFORM(WIN)

Do you need this? Isn't WinLauncher windows only?

Comment 6 Brent Fulgham 2014-10-13 15:47:13 PDT

Comment on attachment 239751 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239751&action=review

>> Tools/WinLauncher/PageLoadTestClient.cpp:197
>> +#if PLATFORM(WIN)
> 
> Do you need this? Isn't WinLauncher windows only?

I'm also making some changes in MiniBrowser that will use this code.

Comment 7 Brent Fulgham 2014-10-13 16:10:45 PDT

Committed r174664: <http://trac.webkit.org/changeset/174664>