WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 200155
[Win][MiniBrowser] Remove PageLoadTestClient
https://bugs.webkit.org/show_bug.cgi?id=200155
Summary
[Win][MiniBrowser] Remove PageLoadTestClient
Fujii Hironori
Reported
2019-07-26 00:38:19 PDT
[Win][MiniBrowser] Remove PageLoadTestClient It was added in
Bug 137673
– [Win] Implement a page load profiling tool
Attachments
Patch
(30.79 KB, patch)
2019-07-26 00:40 PDT
,
Fujii Hironori
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Fujii Hironori
Comment 1
2019-07-26 00:40:07 PDT
Created
attachment 374948
[details]
Patch
Brent Fulgham
Comment 2
2019-07-26 10:07:10 PDT
I am fine with removing this code, because we are not currently using this feature (sadly). That said, I do think we need to build up a usable performance tool for Windows (FTW) so I'm filing a bug to remind us to do that.
Brent Fulgham
Comment 3
2019-07-26 10:11:01 PDT
I filed
Bug 200167
to remind us to create a performance monitoring system.
Brent Fulgham
Comment 4
2019-07-26 10:11:52 PDT
Comment on
attachment 374948
[details]
Patch r=me
Fujii Hironori
Comment 5
2019-07-28 19:05:13 PDT
Comment on
attachment 374948
[details]
Patch Clearing flags on attachment: 374948 Committed
r247896
: <
https://trac.webkit.org/changeset/247896
>
Fujii Hironori
Comment 6
2019-07-28 19:05:17 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7
2019-07-28 19:06:18 PDT
<
rdar://problem/53644306
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug