Bug 200155 - [Win][MiniBrowser] Remove PageLoadTestClient
Summary: [Win][MiniBrowser] Remove PageLoadTestClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks: 200167
  Show dependency tree / graph
 
Reported: 2019-07-26 00:38 PDT by Fujii Hironori
Modified: 2019-07-28 19:06 PDT (History)
6 users (show)

See Also:

Attachments
Patch (30.79 KB, patch)
2019-07-26 00:40 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-07-26 00:38:19 PDT 
[Win][MiniBrowser] Remove PageLoadTestClient

It was added in Bug 137673 – [Win] Implement a page load profiling tool
Comment 1 Fujii Hironori 2019-07-26 00:40:07 PDT 
Created attachment 374948 [details]
Patch
Comment 2 Brent Fulgham 2019-07-26 10:07:10 PDT 
I am fine with removing this code, because we are not currently using this feature (sadly).

That said, I do think we need to build up a usable performance tool for Windows (FTW) so I'm filing a bug to remind us to do that.
Comment 3 Brent Fulgham 2019-07-26 10:11:01 PDT 
I filed Bug 200167 to remind us to create a performance monitoring system.
Comment 4 Brent Fulgham 2019-07-26 10:11:52 PDT 
Comment on attachment 374948 [details]
Patch

r=me
Comment 5 Fujii Hironori 2019-07-28 19:05:13 PDT 
Comment on attachment 374948 [details]
Patch

Clearing flags on attachment: 374948

Committed r247896: <https://trac.webkit.org/changeset/247896>
Comment 6 Fujii Hironori 2019-07-28 19:05:17 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-07-28 19:06:18 PDT 
<rdar://problem/53644306>