Summary: | iOS DRT snapshots are limited to the page visible area | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dbates, dfarler, simon.fraser, thorton | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2014-10-12 12:41:49 PDT
Created attachment 239707 [details]
Patch
Are we OK to keep the iPhone models as the default then? I wasn't able to successfully get iPad Air models working. Even if I did, we'd have to do rotation to get the entire 800x600, so I think this is simpler. Comment on attachment 239707 [details] Patch This looks sane to me. Does this patch resolve or help us resolve <rdar://problem/14637393>? Comment on attachment 239707 [details] Patch Rejecting attachment 239707 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 239707, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: portIOS.mm Hunk #1 FAILED at 60. Hunk #2 FAILED at 76. 2 out of 2 hunks FAILED -- saving rejects to file Tools/DumpRenderTree/ios/PixelDumpSupportIOS.mm.rej patching file Tools/DumpRenderTree/mac/DumpRenderTreeWindow.mm Hunk #1 FAILED at 81. 1 out of 1 hunk FAILED -- saving rejects to file Tools/DumpRenderTree/mac/DumpRenderTreeWindow.mm.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Daniel Bates']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/4676569930924032 |