Bug 137624

Summary: Web Inspector: CSS minification should not strip whitespace around calc +/- binary operators
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2014-10-10 14:18:47 PDT 
In production, minified builds we see a warning in our Main.css:
[Warning] Unexpected CSS token: )

See also:
<https://webkit.org/b/137620> Web Inspector: Poor CSS warning message with missing spaces in calc() +/- operation
Comment 1 Radar WebKit Bug Importer 2014-10-10 14:19:14 PDT 
<rdar://problem/18615543>
Comment 2 Joseph Pecoraro 2014-10-10 14:30:40 PDT 
Created attachment 239648 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2014-10-10 14:32:02 PDT 
Attachment 239648 [details] did not pass style-queue:


ERROR: Source/WebInspectorUI/Scripts/cssmin.py:33:  at least two spaces before inline comment  [pep8/E261] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Timothy Hatcher 2014-10-10 15:00:51 PDT 
Comment on attachment 239648 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=239648&action=review

> Source/WebInspectorUI/ChangeLog:15
> +        * Scripts/copy-user-interface-resources-dryrun.rb: Added.

Yay!
Comment 5 WebKit Commit Bot 2014-10-10 15:38:39 PDT 
Comment on attachment 239648 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 239648

Committed r174615: <http://trac.webkit.org/changeset/174615>
Comment 6 WebKit Commit Bot 2014-10-10 15:38:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Joseph Pecoraro 2014-10-10 15:49:39 PDT 
This fixed the appearance of alpha color swatches in production builds.