Bug 137617

Summary:

Various arguments optimisations in codegen fail to account for arguments being in lexical record

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

137621

Bug Blocks:

Attachments:

Description	Flags
Patch	msaboff: review+

Description Oliver Hunt 2014-10-10 10:54:45 PDT

Various arguments optimisations in codegen fail to account for arguments being in lexical record

Comment 1 Oliver Hunt 2014-10-10 10:57:25 PDT

Created attachment 239637 [details]
Patch

Comment 2 Michael Saboff 2014-10-10 11:26:46 PDT

Comment on attachment 239637 [details]
Patch

r=me

Comment 3 Oliver Hunt 2014-10-10 12:03:35 PDT

Committed r174606: <http://trac.webkit.org/changeset/174606>

Comment 4 Andy Estes 2014-10-10 12:50:18 PDT

(In reply to comment #3)
> Committed r174606: <http://trac.webkit.org/changeset/174606>

This change caused a JSC test failure:

https://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/9172/steps/jscore-test/logs/stdio

Comment 5 WebKit Commit Bot 2014-10-10 12:55:10 PDT

Re-opened since this is blocked by bug 137621

Comment 6 Oliver Hunt 2014-10-17 09:07:11 PDT

Committed r174821: <http://trac.webkit.org/changeset/174821>