137617 – Various arguments optimisations in codegen fail to account for arguments being in lexical record

Bug 137617 - Various arguments optimisations in codegen fail to account for arguments being in lexical record

Summary: Various arguments optimisations in codegen fail to account for arguments bein...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Oliver Hunt

URL:
Keywords:

Depends on:	137621
Blocks:
	Show dependency tree / graph

Reported:	2014-10-10 10:54 PDT by Oliver Hunt
Modified:	2014-10-17 09:07 PDT (History)
CC List:	2 users (show)

See Also:

Attachments
Patch (21.31 KB, patch) 2014-10-10 10:57 PDT, Oliver Hunt	msaboff: review+	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Oliver Hunt 2014-10-10 10:54:45 PDT

Various arguments optimisations in codegen fail to account for arguments being in lexical record

Comment 1 Oliver Hunt 2014-10-10 10:57:25 PDT

Created attachment 239637 [details]
Patch

Comment 2 Michael Saboff 2014-10-10 11:26:46 PDT

Comment on attachment 239637 [details]
Patch

r=me

Comment 3 Oliver Hunt 2014-10-10 12:03:35 PDT

Committed r174606: <http://trac.webkit.org/changeset/174606>

Comment 4 Andy Estes 2014-10-10 12:50:18 PDT

(In reply to comment #3)
> Committed r174606: <http://trac.webkit.org/changeset/174606>

This change caused a JSC test failure:

https://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/9172/steps/jscore-test/logs/stdio

Comment 5 WebKit Commit Bot 2014-10-10 12:55:10 PDT

Re-opened since this is blocked by bug 137621

Comment 6 Oliver Hunt 2014-10-17 09:07:11 PDT

Committed r174821: <http://trac.webkit.org/changeset/174821>