| Summary: | Multiple refactors in RenderMathMLOperator | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alejandro G. Castro <alex> | ||||
| Component: | MathML | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alejandro G. Castro
2014-10-10 07:26:58 PDT
Created attachment 239624 [details]
patch
The patch applies over the patch in bug #133845. Comment on attachment 239624 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=239624&action=review > Source/WebCore/ChangeLog:9 > + - Make most of the functions private, we needed to create some API > + and move trailingSpaceError to RenderMathMLOperator. To be pedantic, the new member functions are needed because of making data members private, not functions. Also, I personally wouldn't use the term API to mean public functions here; there’s no “app”. (In reply to comment #3) > (From update of attachment 239624 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=239624&action=review > > > Source/WebCore/ChangeLog:9 > > + - Make most of the functions private, we needed to create some API > > + and move trailingSpaceError to RenderMathMLOperator. > > To be pedantic, the new member functions are needed because of making data members private, not functions. Also, I personally wouldn't use the term API to mean public functions here; there’s no “app”. I'll fix that, thanks :). Landed http://trac.webkit.org/changeset/174678 Thanks! |