Bug 137611

Summary: Multiple refactors in RenderMathMLOperator
Product: WebKit Reporter: Alejandro G. Castro <alex>
Component: MathMLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Alejandro G. Castro
Reported 2014-10-10 07:26:58 PDT
Clean the code in RenderMathMLOperator following suggestions in bug #136883.
Attachments
patch (22.88 KB, patch)
2014-10-10 07:41 PDT, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alejandro G. Castro
Comment 1 2014-10-10 07:41:30 PDT
Created attachment 239624 [details] patch
Alejandro G. Castro
Comment 2 2014-10-10 07:58:42 PDT
The patch applies over the patch in bug #133845.
Darin Adler
Comment 3 2014-10-10 09:41:25 PDT
Comment on attachment 239624 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=239624&action=review > Source/WebCore/ChangeLog:9 > + - Make most of the functions private, we needed to create some API > + and move trailingSpaceError to RenderMathMLOperator. To be pedantic, the new member functions are needed because of making data members private, not functions. Also, I personally wouldn't use the term API to mean public functions here; there’s no “app”.
Alejandro G. Castro
Comment 4 2014-10-14 02:59:35 PDT
(In reply to comment #3) > (From update of attachment 239624 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=239624&action=review > > > Source/WebCore/ChangeLog:9 > > + - Make most of the functions private, we needed to create some API > > + and move trailingSpaceError to RenderMathMLOperator. > > To be pedantic, the new member functions are needed because of making data members private, not functions. Also, I personally wouldn't use the term API to mean public functions here; there’s no “app”. I'll fix that, thanks :).
Alejandro G. Castro
Comment 5 2014-10-14 03:06:19 PDT
Landed http://trac.webkit.org/changeset/174678 Thanks!
Note You need to log in before you can comment on or make changes to this bug.