Bug 137607

Summary:

Add tiny version to generate-webkitversion.pl

Product:

WebKit

Reporter:

Adrien Destugues <pulkomandy>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Adrien Destugues 2014-10-10 04:38:07 PDT

Add tiny version to generate-webkitversion.pl

Comment 1 Adrien Destugues 2014-10-10 04:40:56 PDT

Created attachment 239618 [details]
Patch

Comment 2 Alexey Proskuryakov 2014-10-10 09:36:44 PDT

Comment on attachment 239618 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239618&action=review

> Source/WebKit/ChangeLog:8
> +        WebKit version now has a third "tiny" number. Extract it from the

This explains what the patch does, but not why. Can you share the reasons why such a macro is necessary?

Comment 3 Adrien Destugues 2014-10-10 09:57:10 PDT

The Haiku port of WebKit shows the tiny verson in the about box to help identifying which version of WebKit is used. The mjor/minor versions don't change often enough to be useful for that.

Comment 4 Michael Catanzaro 2016-09-17 07:05:00 PDT

Comment on attachment 239618 [details]
Patch

Hi,

Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting.

To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.