| Summary: | Use is<>() / downcast<>() for GraphicsLayer subclasses | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||
| Component: | Platform | Assignee: | Chris Dumez <cdumez> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | benjamin, buildbot, commit-queue, darin, kling, kondapallykalyan, rniwa, sergio, simon.fraser | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | 137056 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Chris Dumez
2014-10-09 21:03:46 PDT
Created attachment 239599 [details]
Patch
Comment on attachment 239599 [details] Patch Attachment 239599 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5451520141164544 New failing tests: mathml/opentype/munderover-window-resize.html Created attachment 239606 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 239627 [details]
Patch
Comment on attachment 239627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239627&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3200 > size_t numChildren = childLayers.size(); > for (size_t i = 0; i < numChildren; ++i) { Should use a modern for loop. > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3203 > clonalSublayers.append(childLayer); Should be childLayer.release(). Created attachment 239632 [details]
Patch
Comment on attachment 239632 [details] Patch Clearing flags on attachment: 239632 Committed r174602: <http://trac.webkit.org/changeset/174602> All reviewed patches have been landed. Closing bug. |