Summary: | [iOS] DumpRenderTree fails to render every other test when pixel tests are on | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Farler <dfarler> | ||||
Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dbates, ddkilzer, simon.fraser | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | iPhone / iPad | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 139314 | ||||||
Attachments: |
|
Description
David Farler
2014-10-09 16:04:56 PDT
Specify your `-runtime` as necessary Another effect that I noticed here after smfr's change to wait for the web thread is that if you keep passing in tests with pixel dumps requested, essentially every other test will do the right thing, otherwise resetting to a blank view. Before, it would always be "one behind." So, there's still some state getting in the way. This behavior only happens with --pixel-tests passed at the command line to DumpRenderTree (all tests in server loop mode are pixel tests), or '-p is appended to individual tests in server loop mode. In light of this, I'm retitling the bug to reflect this. Created attachment 242643 [details]
Patch
Comment on attachment 242643 [details] Patch Clearing flags on attachment: 242643 Committed r176872: <http://trac.webkit.org/changeset/176872> All reviewed patches have been landed. Closing bug. |