Bug 137575

Summary:

Web Inspector: paint flashing mode should be disabled when remote inspecting legacy iOS versions

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, simon.fraser, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	simon.fraser: review+
[PATCH] For Bots	none

Description Brian Burg 2014-10-09 15:03:26 PDT

It doesn't do anything on legacy iOS, AFAICT. If it was supposed to be shipped with iOS 8, then this bug should be changed to "paint flashing is broken when remote inspecting iOS 8".

Comment 1 Radar WebKit Bug Importer 2014-10-09 15:04:14 PDT

<rdar://problem/18602659>

Comment 2 Joseph Pecoraro 2014-10-13 13:47:44 PDT

This should just be removing "PageAgent.setShowPaintRects" from the Legacy Inspector JSON files. They had the method, but they didn't implement it. So they are really falsely reporting that they support it.

Comment 3 Joseph Pecoraro 2014-10-13 17:40:57 PDT

Created attachment 239767 [details]
[PATCH] Proposed Fix

Comment 4 Joseph Pecoraro 2014-10-14 11:31:38 PDT

Created attachment 239809 [details]
[PATCH] For Bots

Comment 5 WebKit Commit Bot 2014-10-14 12:29:42 PDT

Comment on attachment 239809 [details]
[PATCH] For Bots

Clearing flags on attachment: 239809

Committed r174696: <http://trac.webkit.org/changeset/174696>

Comment 6 WebKit Commit Bot 2014-10-14 12:29:46 PDT

All reviewed patches have been landed.  Closing bug.