Bug 137575 - Web Inspector: paint flashing mode should be disabled when remote inspecting legacy iOS versions
Summary: Web Inspector: paint flashing mode should be disabled when remote inspecting ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-10-09 15:03 PDT by Brian Burg
Modified: 2014-10-14 12:29 PDT (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (8.67 KB, patch)
2014-10-13 17:40 PDT, Joseph Pecoraro 		simon.fraser: review+
Details | Formatted Diff | Diff
[PATCH] For Bots (8.66 KB, patch)
2014-10-14 11:31 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-10-09 15:03:26 PDT 
It doesn't do anything on legacy iOS, AFAICT. If it was supposed to be shipped with iOS 8, then this bug should be changed to "paint flashing is broken when remote inspecting iOS 8".
Comment 1 Radar WebKit Bug Importer 2014-10-09 15:04:14 PDT 
<rdar://problem/18602659>
Comment 2 Joseph Pecoraro 2014-10-13 13:47:44 PDT 
This should just be removing "PageAgent.setShowPaintRects" from the Legacy Inspector JSON files. They had the method, but they didn't implement it. So they are really falsely reporting that they support it.
Comment 3 Joseph Pecoraro 2014-10-13 17:40:57 PDT 
Created attachment 239767 [details]
[PATCH] Proposed Fix
Comment 4 Joseph Pecoraro 2014-10-14 11:31:38 PDT 
Created attachment 239809 [details]
[PATCH] For Bots
Comment 5 WebKit Commit Bot 2014-10-14 12:29:42 PDT 
Comment on attachment 239809 [details]
[PATCH] For Bots

Clearing flags on attachment: 239809

Committed r174696: <http://trac.webkit.org/changeset/174696>
Comment 6 WebKit Commit Bot 2014-10-14 12:29:46 PDT 
All reviewed patches have been landed.  Closing bug.