Summary: | Web Inspector: Remove unused generator code | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | burg, commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | DoNotImportToRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2014-10-09 12:57:33 PDT
Created attachment 239561 [details]
[PATCH] Proposed Fix
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) Comment on attachment 239561 [details]
[PATCH] Proposed Fix
Looks fine to me. Does this affect any generator test results?
Comment on attachment 239561 [details] [PATCH] Proposed Fix Clearing flags on attachment: 239561 Committed r174559: <http://trac.webkit.org/changeset/174559> All reviewed patches have been landed. Closing bug. (In reply to comment #3) > (From update of attachment 239561 [details]) > Looks fine to me. Does this affect any generator test results? I should have mentioned I ran tests and they all passed. Thanks for the review! |