Bug 137564

Summary: Web Inspector: Remove unused generator code
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: burg, commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2014-10-09 12:57:33 PDT
Some unused code in the generator. Lets clean it up.
Comment 1 Joseph Pecoraro 2014-10-09 12:59:04 PDT
Created attachment 239561 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2014-10-09 13:01:46 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 3 Brian Burg 2014-10-09 13:36:39 PDT
Comment on attachment 239561 [details]
[PATCH] Proposed Fix

Looks fine to me. Does this affect any generator test results?
Comment 4 WebKit Commit Bot 2014-10-09 22:53:58 PDT
Comment on attachment 239561 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 239561

Committed r174559: <http://trac.webkit.org/changeset/174559>
Comment 5 WebKit Commit Bot 2014-10-09 22:54:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Joseph Pecoraro 2014-10-10 11:24:32 PDT
(In reply to comment #3)
> (From update of attachment 239561 [details])
> Looks fine to me. Does this affect any generator test results?

I should have mentioned I ran tests and they all passed. Thanks for the review!