Bug 137556

Summary: [EFL] m_soupRequestManager was not declared
Product: WebKit Reporter: KwangHyuk <hyuki.kim>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: CLOSED DUPLICATE    
Severity: Normal CC: cdumez, lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Fix build break casued by undeclared variable m_soupRequestManager. cdumez: review-

Description KwangHyuk 2014-10-09 05:49:29 PDT
There is compilation error caused by undeclared variable for the webkit efl debug build.

/home/hyuki/git/webkit2/Source/WebKit2/UIProcess/efl/RequestManagerClientEfl.cpp: In constructor ‘WebKit::RequestManagerClientEfl::RequestManagerClientEfl(WKContextRef)’:
/home/hyuki/git/webkit2/Source/WebKit2/UIProcess/efl/RequestManagerClientEfl.cpp:42:12: error: ‘m_soupRequestManager’ was not declared in this scope
     ASSERT(m_soupRequestManager);
            ^
/home/hyuki/git/webkit2/Source/WTF/wtf/Assertions.h:232:8: note: in definition of macro ‘ASSERT’
     (!(assertion) ? \
        ^
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/efl/ViewClientEfl.cpp.o
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/efl/WebColorPickerClient.cpp.o
make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/efl/RequestManagerClientEfl.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2
Comment 1 KwangHyuk 2014-10-09 05:59:24 PDT
Created attachment 239530 [details]
Fix build break casued by undeclared variable m_soupRequestManager.
Comment 2 Chris Dumez 2014-10-10 10:22:53 PDT
Comment on attachment 239530 [details]
Fix build break casued by undeclared variable m_soupRequestManager.

https://bugs.webkit.org/show_bug.cgi?id=137613 seems like a better fix.
Comment 3 KwangHyuk 2014-10-10 10:33:14 PDT
(In reply to comment #2)
> (From update of attachment 239530 [details])
> https://bugs.webkit.org/show_bug.cgi?id=137613 seems like a better fix.

Thx for your review. :)
Agree with you. So, close this bug.
Comment 4 KwangHyuk 2014-10-10 10:34:11 PDT

*** This bug has been marked as a duplicate of bug 137613 ***