Bug 137551

Summary: [iOS] Crash in CFURLDownloadClient.didFail if the download has a null resumeData
Product: WebKit Reporter: Andy Estes <aestes>
Component: Page LoadingAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, ddkilzer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ddkilzer: review+

Andy Estes
Reported 2014-10-09 00:16:08 PDT
[iOS] Crash in CFURLDownloadClient.didFail if the download has a null resumeData
Attachments
Patch (1.76 KB, patch)
2014-10-09 00:19 PDT, Andy Estes 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2014-10-09 00:19:18 PDT
Created attachment 239522 [details] Patch
Andy Estes
Comment 2 2014-10-09 00:19:49 PDT
rdar://problem/17316756
David Kilzer (:ddkilzer)
Comment 3 2014-10-09 02:43:13 PDT
Comment on attachment 239522 [details] Patch r=me
Alexey Proskuryakov
Comment 4 2014-10-09 10:56:02 PDT
Do we have steps to reproduce? Does this happen with all servers that don't support resuming?
Andy Estes
Comment 5 2014-10-09 11:08:21 PDT
(In reply to comment #4) > Do we have steps to reproduce? No, this is a speculative fix based on looking at crash reports. > Does this happen with all servers that don't support resuming? I don't know how to answer that question. I know that CFURLDownloadCopyResumeData() can return null and that we should handle it (this patch aligns our behavior with that of the Mac; e.g. passing a 0-length DataReference to DownloadProxy::didFail).
Andy Estes
Comment 6 2014-10-09 11:16:25 PDT
Committed r174512: <http://trac.webkit.org/changeset/174512>
Note You need to log in before you can comment on or make changes to this bug.