Summary: | Use is<>() / downcast<>() for Widget subclasses | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | Platform | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, commit-queue, darin, kling, rniwa | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 137056 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Chris Dumez
2014-10-08 21:26:51 PDT
Created attachment 239515 [details]
Patch
Attachment 239515 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/Widget.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 51 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 239516 [details]
Patch
Created attachment 239517 [details]
Patch
Comment on attachment 239517 [details] Patch Clearing flags on attachment: 239517 Committed r174506: <http://trac.webkit.org/changeset/174506> All reviewed patches have been landed. Closing bug. |