Bug 137549

Summary: Use is<>() / downcast<>() for Widget subclasses
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: PlatformAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137056    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2014-10-08 21:26:51 PDT
Use is<>() / downcast<>() for Widget subclasses
Attachments
Patch (71.67 KB, patch)
2014-10-08 21:45 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (72.15 KB, patch)
2014-10-08 21:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (72.15 KB, patch)
2014-10-08 22:01 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-10-08 21:45:22 PDT
Created attachment 239515 [details] Patch
WebKit Commit Bot
Comment 2 2014-10-08 21:47:36 PDT
Attachment 239515 [details] did not pass style-queue: ERROR: Source/WebCore/platform/Widget.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 51 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 3 2014-10-08 21:55:35 PDT
Created attachment 239516 [details] Patch
Chris Dumez
Comment 4 2014-10-08 22:01:51 PDT
Created attachment 239517 [details] Patch
WebKit Commit Bot
Comment 5 2014-10-09 09:45:35 PDT
Comment on attachment 239517 [details] Patch Clearing flags on attachment: 239517 Committed r174506: <http://trac.webkit.org/changeset/174506>
WebKit Commit Bot
Comment 6 2014-10-09 09:45:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.