Bug 137549 - Use is<>() / downcast<>() for Widget subclasses
Summary: Use is<>() / downcast<>() for Widget subclasses
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 137056
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-08 21:26 PDT by Chris Dumez
Modified: 2014-10-09 09:45 PDT (History)
5 users (show)

See Also:

Attachments
Patch (71.67 KB, patch)
2014-10-08 21:45 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (72.15 KB, patch)
2014-10-08 21:55 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (72.15 KB, patch)
2014-10-08 22:01 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-10-08 21:26:51 PDT 
Use is<>() / downcast<>() for Widget subclasses
Comment 1 Chris Dumez 2014-10-08 21:45:22 PDT 
Created attachment 239515 [details]
Patch
Comment 2 WebKit Commit Bot 2014-10-08 21:47:36 PDT 
Attachment 239515 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/Widget.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 51 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2014-10-08 21:55:35 PDT 
Created attachment 239516 [details]
Patch
Comment 4 Chris Dumez 2014-10-08 22:01:51 PDT 
Created attachment 239517 [details]
Patch
Comment 5 WebKit Commit Bot 2014-10-09 09:45:35 PDT 
Comment on attachment 239517 [details]
Patch

Clearing flags on attachment: 239517

Committed r174506: <http://trac.webkit.org/changeset/174506>
Comment 6 WebKit Commit Bot 2014-10-09 09:45:39 PDT 
All reviewed patches have been landed.  Closing bug.