Bug 137547

Summary: Web Inspector: DOM Storage Editing is broken in many ways, frustrating
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2014-10-08 20:34:40 PDT
DOM Storage editing is broken in many ways. * STEPS TO REPRODUCE 1. Load <http://bogojoker.com> 2. Start adding keys / values to local storage 3. Start editing existing keys / values 4. Right click a row => exception in console 5. Double click a value, change it, and hit Enter to commit the change => value is still editable 6. Edit a key to be a duplicate of another key, then change to a new value => non-edited row that was temporarily a duplicate is now gone
Attachments
[PATCH] Proposed Fix (12.15 KB, patch)
2014-10-08 20:38 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-10-08 20:34:49 PDT
<rdar://problem/18592458>
Joseph Pecoraro
Comment 2 2014-10-08 20:38:37 PDT
Created attachment 239514 [details] [PATCH] Proposed Fix
Timothy Hatcher
Comment 3 2014-10-09 09:56:45 PDT
Comment on attachment 239514 [details] [PATCH] Proposed Fix Much cleaner!
WebKit Commit Bot
Comment 4 2014-10-09 10:34:08 PDT
Comment on attachment 239514 [details] [PATCH] Proposed Fix Clearing flags on attachment: 239514 Committed r174510: <http://trac.webkit.org/changeset/174510>
WebKit Commit Bot
Comment 5 2014-10-09 10:34:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.