Bug 137422

Summary: [GTK] Move GtkDragAndDropHelper from Platform to WebKit2
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, commit-queue, gustavo, gyuyoung.kim, mrobinson, rakuco, ryuan.choi, sergio
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Updated patch to move all the dnd logic to a class mrobinson: review+

Carlos Garcia Campos
Reported 2014-10-04 04:40:38 PDT
WebKitWebViewBase is currently the only user of GtkDragAndDropHelper, that was added to share the code with WebKit1. This removes another file in platform that is built twice for the plugin process.
Attachments
Patch (24.14 KB, patch)
2014-10-04 04:42 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated patch to move all the dnd logic to a class (45.04 KB, patch)
2014-10-17 10:07 PDT, Carlos Garcia Campos 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2014-10-04 04:42:30 PDT
Created attachment 239278 [details] Patch
WebKit Commit Bot
Comment 2 2014-10-04 04:44:19 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Martin Robinson
Comment 3 2014-10-04 13:53:40 PDT
Comment on attachment 239278 [details] Patch I think it's cleaner to keep the drag and drop support separate from the rest of the widget. What if we just move this file to the WebKit2 directory?
Carlos Garcia Campos
Comment 4 2014-10-05 00:34:42 PDT
(In reply to comment #3) > (From update of attachment 239278 [details]) > I think it's cleaner to keep the drag and drop support separate from the rest of the widget. What if we just move this file to the WebKit2 directory? Well, I don't think the current class is cleaner, it was only needed to share the code with WebKit1, but I never liked some things like setWidget() or the DragExited callback. In some cases the handleFoo methods are just one line of code, so I don't think another unneeded layer makes things cleaner.
Carlos Garcia Campos
Comment 5 2014-10-17 10:07:01 PDT
Created attachment 240018 [details] Updated patch to move all the dnd logic to a class
Carlos Garcia Campos
Comment 6 2014-10-19 00:33:24 PDT
Committed r174868: <http://trac.webkit.org/changeset/174868>
Note You need to log in before you can comment on or make changes to this bug.