Bug 137422

Summary:

[GTK] Move GtkDragAndDropHelper from Platform to WebKit2

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, commit-queue, gustavo, gyuyoung.kim, mrobinson, rakuco, ryuan.choi, sergio

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Updated patch to move all the dnd logic to a class	mrobinson: review+

Description Carlos Garcia Campos 2014-10-04 04:40:38 PDT

WebKitWebViewBase is currently the only user of GtkDragAndDropHelper, that was added to share the code with WebKit1. This removes another file in platform that is built twice for the plugin process.

Comment 1 Carlos Garcia Campos 2014-10-04 04:42:30 PDT

Created attachment 239278 [details]
Patch

Comment 2 WebKit Commit Bot 2014-10-04 04:44:19 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 3 Martin Robinson 2014-10-04 13:53:40 PDT

Comment on attachment 239278 [details]
Patch

I think it's cleaner to keep the drag and drop support separate from the rest of the widget. What if we just move this file to the WebKit2 directory?

Comment 4 Carlos Garcia Campos 2014-10-05 00:34:42 PDT

(In reply to comment #3)
> (From update of attachment 239278 [details])
> I think it's cleaner to keep the drag and drop support separate from the rest of the widget. What if we just move this file to the WebKit2 directory?

Well, I don't think the current class is cleaner, it was only needed to share the code with WebKit1, but I never liked some things like setWidget() or the DragExited callback. In some cases the handleFoo methods are just one line of code, so I don't think another unneeded layer makes things cleaner.

Comment 5 Carlos Garcia Campos 2014-10-17 10:07:01 PDT

Created attachment 240018 [details]
Updated patch to move all the dnd logic to a class

Comment 6 Carlos Garcia Campos 2014-10-19 00:33:24 PDT

Committed r174868: <http://trac.webkit.org/changeset/174868>