Bug 137410

Summary: Bugzilla status bubble displays an exception showing attachment 175738
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://webkit-queues.appspot.com/status-bubble/175738
Attachments:
Description Flags
proposed fix thorton: review+

Alexey Proskuryakov
Reported 2014-10-03 15:51:48 PDT
This old attachment has an incorrect status queue log. We should be tolerant of that.
Attachments
proposed fix (3.67 KB, patch)
2014-10-03 15:54 PDT, Alexey Proskuryakov 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-10-03 15:54:20 PDT
Created attachment 239247 [details] proposed fix
Tim Horton
Comment 2 2014-10-03 16:33:22 PDT
Comment on attachment 239247 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=239247&action=review > Tools/QueueStatusServer/app.yaml:2 > +version: ap # Bugzilla bug ID of last major change please fix the comment. > Tools/QueueStatusServer/handlers/statusbubble.py:141 > + message_to_display = statuses[1].message if len(statuses) > 1 else statuses[0].message IIRC 'if statuses' is sufficient (an empty list evaluates to false) but this is probably clearer
Alexey Proskuryakov
Comment 3 2014-10-03 16:37:08 PDT
Committed <http://trac.webkit.org/r174303>.
Tim Horton
Comment 4 2014-10-03 16:37:43 PDT
Comment on attachment 239247 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=239247&action=review >> Tools/QueueStatusServer/handlers/statusbubble.py:141 >> + message_to_display = statuses[1].message if len(statuses) > 1 else statuses[0].message > > IIRC 'if statuses' is sufficient (an empty list evaluates to false) but this is probably clearer Nevermind!
Alexey Proskuryakov
Comment 5 2014-10-03 16:49:20 PDT
Actually committed in 174304
Note You need to log in before you can comment on or make changes to this bug.