| Summary: | Bugzilla status bubble displays an exception showing attachment 175738 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
| Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | rniwa | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | http://webkit-queues.appspot.com/status-bubble/175738 | ||||||
| Attachments: |
|
||||||
|
Description
Alexey Proskuryakov
2014-10-03 15:51:48 PDT
Created attachment 239247 [details]
proposed fix
Comment on attachment 239247 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=239247&action=review > Tools/QueueStatusServer/app.yaml:2 > +version: ap # Bugzilla bug ID of last major change please fix the comment. > Tools/QueueStatusServer/handlers/statusbubble.py:141 > + message_to_display = statuses[1].message if len(statuses) > 1 else statuses[0].message IIRC 'if statuses' is sufficient (an empty list evaluates to false) but this is probably clearer Committed <http://trac.webkit.org/r174303>. Comment on attachment 239247 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=239247&action=review >> Tools/QueueStatusServer/handlers/statusbubble.py:141 >> + message_to_display = statuses[1].message if len(statuses) > 1 else statuses[0].message > > IIRC 'if statuses' is sufficient (an empty list evaluates to false) but this is probably clearer Nevermind! Actually committed in 174304 |