Bug 137398

Summary: Use is<>() / downcast<>() for CSS StyleProperties
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137056    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2014-10-03 13:03:12 PDT
Use is<>() / downcast<>() for CSS StyleProperties subclasses.
Attachments
Patch (12.07 KB, patch)
2014-10-03 13:25 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (12.09 KB, patch)
2014-10-03 16:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-10-03 13:25:25 PDT
Created attachment 239223 [details] Patch
Chris Dumez
Comment 2 2014-10-03 16:55:34 PDT
Created attachment 239255 [details] Patch
Benjamin Poulain
Comment 3 2014-10-03 21:04:35 PDT
Comment on attachment 239255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239255&action=review > Source/WebCore/css/StyleProperties.h:286 > + static bool isType(const WebCore::StyleProperties& set) { return set.isMutable(); } Never noticed that before, but those functions aren't const...
Chris Dumez
Comment 4 2014-10-04 00:52:15 PDT
Comment on attachment 239255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239255&action=review >> Source/WebCore/css/StyleProperties.h:286 >> + static bool isType(const WebCore::StyleProperties& set) { return set.isMutable(); } > > Never noticed that before, but those functions aren't const... they are static
WebKit Commit Bot
Comment 5 2014-10-04 01:30:20 PDT
Comment on attachment 239255 [details] Patch Clearing flags on attachment: 239255 Committed r174313: <http://trac.webkit.org/changeset/174313>
WebKit Commit Bot
Comment 6 2014-10-04 01:30:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.