Bug 137398 - Use is<>() / downcast<>() for CSS StyleProperties
Summary: Use is<>() / downcast<>() for CSS StyleProperties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 137056
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-03 13:03 PDT by Chris Dumez
Modified: 2014-10-04 01:30 PDT (History)
1 user (show)

See Also:


Attachments
Patch (12.07 KB, patch)
2014-10-03 13:25 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (12.09 KB, patch)
2014-10-03 16:55 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-10-03 13:03:12 PDT
Use is<>() / downcast<>() for CSS StyleProperties subclasses.
Comment 1 Chris Dumez 2014-10-03 13:25:25 PDT
Created attachment 239223 [details]
Patch
Comment 2 Chris Dumez 2014-10-03 16:55:34 PDT
Created attachment 239255 [details]
Patch
Comment 3 Benjamin Poulain 2014-10-03 21:04:35 PDT
Comment on attachment 239255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239255&action=review

> Source/WebCore/css/StyleProperties.h:286
> +    static bool isType(const WebCore::StyleProperties& set) { return set.isMutable(); }

Never noticed that before, but those functions aren't const...
Comment 4 Chris Dumez 2014-10-04 00:52:15 PDT
Comment on attachment 239255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239255&action=review

>> Source/WebCore/css/StyleProperties.h:286
>> +    static bool isType(const WebCore::StyleProperties& set) { return set.isMutable(); }
> 
> Never noticed that before, but those functions aren't const...

they are static
Comment 5 WebKit Commit Bot 2014-10-04 01:30:20 PDT
Comment on attachment 239255 [details]
Patch

Clearing flags on attachment: 239255

Committed r174313: <http://trac.webkit.org/changeset/174313>
Comment 6 WebKit Commit Bot 2014-10-04 01:30:24 PDT
All reviewed patches have been landed.  Closing bug.