Bug 137383

Summary: WKWebView snapshot of Daring Fireball has the wrong color in the obscured inset
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, commit-queue, dbates, esprehn+autocc, glenn, ian, kondapallykalyan, mitz, sam, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Description Tim Horton 2014-10-03 00:18:17 PDT
WKWebView snapshot of Daring Fireball has the wrong color in the obscured inset
Comment 1 Tim Horton 2014-10-03 00:19:07 PDT
Created attachment 239183 [details]
Patch
Comment 2 Tim Horton 2014-10-03 00:19:42 PDT
rdar://problem/18535439
Comment 3 Daniel Bates 2014-10-03 10:17:24 PDT
Comment on attachment 239183 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239183&action=review

> Source/WebCore/ChangeLog:11
> +        Use pageExtendedBackgroundColor instead of baseBackgroundColor if backgroundShouldExtendBeyondPage is set.

I take it you meant to write documentBackgroundColor instead of pageExtendedBackgroundColor.

> Source/WebKit2/ChangeLog:11
> +        Use pageExtendedBackgroundColor instead of baseBackgroundColor if backgroundShouldExtendBeyondPage is set.

Ditto.

> Source/WebCore/rendering/RenderView.cpp:590
> +        Color backgroundColor = backgroundShouldExtendBeyondPage ? frameView().documentBackgroundColor() : frameView().baseBackgroundColor();

Should we add a remark about this in the comment block that starts at line 583: <http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderView.cpp?rev=173865#L583>?
Comment 4 Tim Horton 2014-10-03 13:37:11 PDT
http://trac.webkit.org/changeset/174287