| Summary: | WKWebView snapshot of Daring Fireball has the wrong color in the obscured inset | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, bdakin, commit-queue, dbates, esprehn+autocc, glenn, ian, kondapallykalyan, mitz, sam, simon.fraser | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2014-10-03 00:18:17 PDT
Created attachment 239183 [details]
Patch
Comment on attachment 239183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239183&action=review > Source/WebCore/ChangeLog:11 > + Use pageExtendedBackgroundColor instead of baseBackgroundColor if backgroundShouldExtendBeyondPage is set. I take it you meant to write documentBackgroundColor instead of pageExtendedBackgroundColor. > Source/WebKit2/ChangeLog:11 > + Use pageExtendedBackgroundColor instead of baseBackgroundColor if backgroundShouldExtendBeyondPage is set. Ditto. > Source/WebCore/rendering/RenderView.cpp:590 > + Color backgroundColor = backgroundShouldExtendBeyondPage ? frameView().documentBackgroundColor() : frameView().baseBackgroundColor(); Should we add a remark about this in the comment block that starts at line 583: <http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderView.cpp?rev=173865#L583>? |