Summary: | -asan-blacklist option also renamed to generic -fsanitize-blacklist | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Farler <dfarler> | ||||
Component: | Tools / Tests | Assignee: | David Farler <dfarler> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dbates, dburkart, ddkilzer, jake.nielsen.webkit | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
David Farler
2014-10-02 18:41:11 PDT
Created attachment 239172 [details]
Patch
Comment on attachment 239172 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239172&action=review > Tools/ChangeLog:9 > + * asan/asan.xcconfig: > + -asan-blacklist -> -fsanitize-blacklist Do we know version/revision of clang added support for -fsanitize-blacklist? If so, or if it's straightforward to determine this, then I suggest we add a remark to this change log entry about the version/revision of clang that added such support. (In reply to comment #2) > (From update of attachment 239172 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=239172&action=review > > > Tools/ChangeLog:9 > > + * asan/asan.xcconfig: > > + -asan-blacklist -> -fsanitize-blacklist > > Do we know version/revision of clang added support for -fsanitize-blacklist? [...] I meant to write: Do we know which version/revision of clang added support for -fsanitize-blacklist? (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 239172 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=239172&action=review > > > > > Tools/ChangeLog:9 > > > + * asan/asan.xcconfig: > > > + -asan-blacklist -> -fsanitize-blacklist > > > > Do we know version/revision of clang added support for -fsanitize-blacklist? [...] > > I meant to write: > > Do we know which version/revision of clang added support for -fsanitize-blacklist? -fsanitize-blacklist is a generic option that has been available for quite some time, way before ASan was available. I’ll reference the same revision in my previous patch. Committed r174290: <http://trac.webkit.org/changeset/174290> |