Bug 137377

Summary: -asan-blacklist option also renamed to generic -fsanitize-blacklist
Product: WebKit Reporter: David Farler <dfarler>
Component: Tools / TestsAssignee: David Farler <dfarler>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, dburkart, ddkilzer, jake.nielsen.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch dbates: review+

David Farler
Reported 2014-10-02 18:41:11 PDT
In addition to the ASan flags moving up to the clang front-end, the generic -fsanitize-blacklist is now used for the ASan symbol blacklist as well.
Attachments
Patch (1.37 KB, patch)
2014-10-02 18:49 PDT, David Farler 		dbates: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Farler
Comment 1 2014-10-02 18:49:39 PDT
Created attachment 239172 [details] Patch
Daniel Bates
Comment 2 2014-10-03 10:32:54 PDT
Comment on attachment 239172 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239172&action=review > Tools/ChangeLog:9 > + * asan/asan.xcconfig: > + -asan-blacklist -> -fsanitize-blacklist Do we know version/revision of clang added support for -fsanitize-blacklist? If so, or if it's straightforward to determine this, then I suggest we add a remark to this change log entry about the version/revision of clang that added such support.
Daniel Bates
Comment 3 2014-10-03 10:33:51 PDT
(In reply to comment #2) > (From update of attachment 239172 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=239172&action=review > > > Tools/ChangeLog:9 > > + * asan/asan.xcconfig: > > + -asan-blacklist -> -fsanitize-blacklist > > Do we know version/revision of clang added support for -fsanitize-blacklist? [...] I meant to write: Do we know which version/revision of clang added support for -fsanitize-blacklist?
David Farler
Comment 4 2014-10-03 14:16:20 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 239172 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=239172&action=review > > > > > Tools/ChangeLog:9 > > > + * asan/asan.xcconfig: > > > + -asan-blacklist -> -fsanitize-blacklist > > > > Do we know version/revision of clang added support for -fsanitize-blacklist? [...] > > I meant to write: > > Do we know which version/revision of clang added support for -fsanitize-blacklist? -fsanitize-blacklist is a generic option that has been available for quite some time, way before ASan was available. I’ll reference the same revision in my previous patch.
David Farler
Comment 5 2014-10-03 14:18:42 PDT
Committed r174290: <http://trac.webkit.org/changeset/174290>
Note You need to log in before you can comment on or make changes to this bug.