Bug 137344

Summary: Suppress warnings on GCC: google-tests header mis-recognize false as null literal
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: cdumez, commit-queue, gyuyoung.kim, kling, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cdumez: review+, commit-queue: commit-queue-

Yusuke Suzuki
Reported 2014-10-02 08:44:54 PDT
Suppress warnings on GCC: google-tests header mis-recognize false as null literal
Attachments
Patch (4.89 KB, patch)
2014-10-02 08:48 PDT, Yusuke Suzuki 		cdumez: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2014-10-02 08:48:53 PDT
Created attachment 239111 [details] Patch
Chris Dumez
Comment 2 2014-10-03 16:27:13 PDT
Comment on attachment 239111 [details] Patch r=me
WebKit Commit Bot
Comment 3 2014-10-03 18:57:13 PDT
Comment on attachment 239111 [details] Patch Rejecting attachment 239111 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 239111, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: de: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp Hunk #1 FAILED at 166. Hunk #2 FAILED at 218. 2 out of 2 hunks FAILED -- saving rejects to file Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Christophe Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5926707538165760
Yusuke Suzuki
Comment 4 2014-10-03 19:13:36 PDT
Ah, the other patch contains this patch's change. https://bugs.webkit.org/show_bug.cgi?id=137360 Thank you for your review, Chris :) *** This bug has been marked as a duplicate of bug 137360 ***
Note You need to log in before you can comment on or make changes to this bug.