| Summary: | [Subpixel] Use floats instead of ints for text justification expansion, and associated cleanup | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, darin, dino, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, jonlee, kling, kondapallykalyan, pdr, pm, rniwa, schenney, sergio, simon.fraser, thorton, zalan | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Myles C. Maxfield
2014-10-01 17:27:36 PDT
Created attachment 239072 [details]
Patch
Created attachment 239074 [details]
Patch
Created attachment 239122 [details]
Patch
Comment on attachment 239122 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239122&action=review Looks good to me. Andreas, do you think expanding the InlineBox size is still an issue now that we've got simple line layout? > Source/WebCore/ChangeLog:3 > + [Subpixel] Use floats instead of ints for text justification expansion, and associated cleanup minus the "associated cleanup" (In reply to comment #4) > (From update of attachment 239122 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=239122&action=review > > Looks good to me. Andreas, do you think expanding the InlineBox size is still an issue now that we've got simple line layout? I think it's okay to grow InlineBox a bit. Yay for simple line layout! Comment on attachment 239122 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239122&action=review > Source/WebCore/rendering/InlineBox.h:283 > + float m_expansion; Private? Comment on attachment 239122 [details] Patch Attachment 239122 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5558973243588608 Number of test failures exceeded the failure limit. Created attachment 239128 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 239122 [details] Patch Attachment 239122 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6574436924784640 Number of test failures exceeded the failure limit. Created attachment 239130 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 239122 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239122&action=review >> Source/WebCore/ChangeLog:3 >> + [Subpixel] Use floats instead of ints for text justification expansion, and associated cleanup > > minus the "associated cleanup" Done. >> Source/WebCore/rendering/InlineBox.h:283 >> + float m_expansion; > > Private? Done. *** Bug 137016 has been marked as a duplicate of this bug. *** |